Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace NVDA's start, exit, error, browse mode and focus mode sounds #7218

Closed
wants to merge 1 commit into from

Conversation

jcsteh
Copy link
Contributor

@jcsteh jcsteh commented May 30, 2017

…with more modern, subtle sounds.

Link to issue number:

Fixes #5382.

Summary of the issue:

  • NVDA's current browse mode and focus mode sounds are rather jarring and unpleasant, particularly when using headphones.
  • The start and exit sounds draw attention and are rather long, which makes restarts slower.
  • There's no functional reason to change the error sound, but since we're changing the other sounds and modernising them in the process, it makes sense to do the same for the error sound.
  • See change different auditory indications or sounds of NVDA #5382, Changing the sound effects for NVDA #1007 and Change NVDA Sounds #5978 for user requests, but there have also been several other discussions over the years outside of the issue tracker.

Description of how this pull request fixes the issue:

This PR replaces all of these sounds with subtle, modern, short sounds.

Sounds and images have also been moved from miscDeps into the NVDA repository itself, since they're specific to NVDA (not dependencies) and are quite small. Moving images obviously isn't related to sounds, but I figured it made sense to move these in the process rather than doing more miscDeps churn.

Note that the sounds moved include suggestionsOpened and suggestionsClosed, which are part of #6274 which is not yet in master. However, it will be merged to master soon enough, and again, I wanted to avoid more miscDeps churn.

Testing performed:

These sounds were actually contributed by others. There has been quite a lot of discussion and feedback from these contributors, as well as from @michaelDCurran, @Qchristensen and @derekriemer.

I've been running with these new sounds locally for a couple of weeks.

I've tested that the new sounds apply correctly in a local build.

Known issues with pull request:

Change log entry:

In Changes:

- NVDA's start, exit, browse mode and focus mode sounds have been replaced with subtle, modern, short sounds. (##5382)

Note that I don't mention the error sound because this won't be noticed by users of stable releases for whom the What's New document is intended.

…with more modern, subtle sounds.

Sounds and images have also been moved from miscDeps into the NVDA repository itself, since they're specific to NVDA (not dependencies) and are quite small.
@jcsteh jcsteh requested a review from feerrenrut May 30, 2017 06:47
@Brian1Gaff
Copy link

Brian1Gaff commented May 30, 2017 via email

@LeonarddeR
Copy link
Collaborator

LeonarddeR commented May 30, 2017 via email

@jcsteh
Copy link
Contributor Author

jcsteh commented May 30, 2017 via email

@Nikita34196
Copy link

Hello. Personally, I liked the old sounds better. But if most of the users were against me.

@derekriemer
Copy link
Collaborator

derekriemer commented May 30, 2017 via email

@derekriemer
Copy link
Collaborator

The browse mode sound is almost entirely left ear. This is a problem because sometimes, I use NVDA with only one ear phone, since I'm in school and want only one headphone on so I can listen with the other ear.

@PratikP1
Copy link

PratikP1 commented May 30, 2017 via email

@Nikita34196
Copy link

I suggest that you keep both versions of the sounds. and make it possible to switch between old and new sounds.

@michaelDCurran
Copy link
Member

michaelDCurran commented May 30, 2017 via email

@PratikP1
Copy link

PratikP1 commented May 30, 2017 via email

@michaelDCurran
Copy link
Member

michaelDCurran commented May 30, 2017 via email

@jcsteh
Copy link
Contributor Author

jcsteh commented May 31, 2017

@derekriemer commented on May 31, 2017, 7:31 AM GMT+10:

The browse mode sound is almost entirely left ear. This is a problem because sometimes, I use NVDA with only one ear phone, since I'm in school and want only one headphone on so I can listen with the other ear.

It's actually two different pitches, one in left and one in right, but they're both the same volume to my ear. I tried using NVDA in just my right ear and I could still hear it quite well. Are you saying it seems quieter to you? I guess we could drop it to mono if this is a major issue.

@gdata1 commented on May 31, 2017, 7:56 AM GMT+10:

I suggest that you keep both versions of the sounds. and make it possible to switch between old and new sounds.

I think this is superfluous. We should either keep the old sounds or switch to new ones.

@PratikP1 commented on May 31, 2017, 7:52 AM GMT+10:

I’m in agreement with @michaelDCurran regarding NVDA startup and shut down sounds.

One real concern I do have (putting all the others aside) is that the exit sound is long enough that it makes restarts feel slow. Perhaps we should just drop the exit sound. Does it really serve any purpose? On a slow machine, you can argue the startup sound helps you to know sooner that NVDA has started, but exit is user triggered and thus the user should already be consciously aware of this.

@jcsteh
Copy link
Contributor Author

jcsteh commented May 31, 2017

@derekriemer commented on May 31, 2017, 3:51 AM GMT+10:

I think you should include all the sound authors in the contributers file
as a thank you.

Um... this PR already does that.

@derekriemer
Copy link
Collaborator

derekriemer commented May 31, 2017 via email

@jcsteh
Copy link
Contributor Author

jcsteh commented Aug 1, 2017

Feedback on this PR, #7393, these two nvda-devel threads, social media and elsewhere suggests that while some users are happy with the new sounds, a significant number of users have concerns (e.g. difficulty in discerning the sounds) or are vehemently opposed to them. As a result, we're going to revert this change, and given the amount of difficulty in satisfying various groups, we are not going to consider any alternatives in the near term. Eventually, our aim would be to allow add-ons to more easily provide sound packs. I'm going to lock comments on this PR; further discussion at this point is not useful. Thanks to those who provided feedback.

@nvaccess nvaccess locked and limited conversation to collaborators Aug 1, 2017
@jcsteh jcsteh closed this Aug 1, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

change different auditory indications or sounds of NVDA
9 participants