-
-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace NVDA's start, exit, error, browse mode and focus mode sounds #7218
Conversation
…with more modern, subtle sounds. Sounds and images have also been moved from miscDeps into the NVDA repository itself, since they're specific to NVDA (not dependencies) and are quite small.
I'm not sure anyone has noticed that this is going to happen at all,
certainly until I came across this post I had not. I think I like the
current sounds myself, but as you say, on headphones they can be jarring as
unfortunately can be the progress bar update noises. a more tuneful fade ina
and out would be nice here, but I do understand that these beeps are in fact
generated from a locally generated number from the percentage, so is
probably not a trivial job to do.
I'll watch next with bated breath. I like the click of edit mode but its a
little too loud.
Brian
bglists@blueyonder.co.uk
Sent via blueyonder.
Please address personal email to:-
briang1@blueyonder.co.uk, putting 'Brian Gaff'
in the display name field.
----- Original Message -----
From: "James Teh" <notifications@github.com>
To: "nvaccess/nvda" <nvda@noreply.github.com>
Cc: "Subscribed" <subscribed@noreply.github.com>
Sent: Tuesday, May 30, 2017 7:47 AM
Subject: [nvaccess/nvda] Replace NVDA's start, exit, error, browse mode and
focus mode sounds (#7218)
…with more modern, subtle sounds.
### Link to issue number:
Fixes #5382.
### Summary of the issue:
- NVDA's current browse mode and focus mode sounds are rather jarring and
unpleasant, particularly when using headphones.
- The start and exit sounds draw attention and are rather long, which makes
restarts slower.
- There's no functional reason to change the error sound, but since we're
changing the other sounds and modernising them in the process, it makes
sense to do the same for the error sound.
- See #5382, #1007 and #5978 for user requests, but there have also been
several other discussions over the years outside of the issue tracker.
### Description of how this pull request fixes the issue:
This PR replaces all of these sounds with subtle, modern, short sounds.
Sounds and images have also been moved from miscDeps into the NVDA
repository itself, since they're specific to NVDA (not dependencies) and are
quite small. Moving images obviously isn't related to sounds, but I figured
it made sense to move these in the process rather than doing more miscDeps
churn.
Note that the sounds moved include suggestionsOpened and suggestionsClosed,
which are part of #6274 which is not yet in master. However, it will be
merged to master soon enough, and again, I wanted to avoid more miscDeps
churn.
### Testing performed:
These sounds were actually contributed by others. There has been quite a lot
of discussion and feedback from these contributors, as well as from
@michaelDCurran, @Qchristensen and @derekriemer.
I've been running with these new sounds locally for a couple of weeks.
I've tested that the new sounds apply correctly in a local build.
### Known issues with pull request:
- This will cause a miscDeps conflict with #6274. This conflict should be
resolved in favour of this PR (#7217) as explained above.
- The start sound is now more an indicator than a logo. That is, it tells
the user that NVDA has started, but it doesn't serve as an audio logo for
branding purposes. I feel this is better: NVDA should be discreet and
shouldn't draw unnecessary attention to itself when it is started apart from
serving its function, especially since some users might be quietly using
speakers in a public environment. However, @michaelDCurran is a little
unsure about this. We agreed to try this on next for a while to see what
users think.
### Change log entry:
In Changes:
```
- NVDA's start, exit, browse mode and focus mode sounds have been replaced
with subtle, modern, short sounds. (##5382)
```
Note that I don't mention the error sound because this won't be noticed by
users of stable releases for whom the What's New document is intended.
You can view, comment on, or merge this pull request online at:
#7218
…-- Commit Summary --
* Replace NVDA's start, exit, error, browse mode and focus mode sounds
with more modern, subtle sounds.
-- File Changes --
M .gitignore (2)
M contributors.txt (2)
M miscDeps (2)
A source/images/nvda.ico (0)
A source/waves/browseMode.wav (0)
A source/waves/error.wav (0)
A source/waves/exit.wav (0)
A source/waves/focusMode.wav (0)
A source/waves/start.wav (0)
A source/waves/suggestionsClosed.wav (0)
A source/waves/suggestionsOpened.wav (0)
A source/waves/textError.wav (0)
-- Patch Links --
https://github.com/nvaccess/nvda/pull/7218.patch
https://github.com/nvaccess/nvda/pull/7218.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
#7218
|
Does this also cover the nVDA logo sound in the Launcher?
|
No; I'm not dealing with the installer logo here. My plan is for that to disappear as well and be replaced by subtle indeterminate progress clicks, but that requires code we don't have yet (since looping sounds with a delay is not possible in NSIS itself), so that needs to be handled separately.
|
Hello. Personally, I liked the old sounds better. But if most of the users were against me. |
I think you should include all the sound authors in the contributers file
as a thank you.
…On Tue, May 30, 2017 at 7:14 AM, nikita ***@***.***> wrote:
Hello. Personally, I liked the old sounds better. But if most of the users
were against me.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#7218 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AFGivUXIXPgBXuG3RN7ETFkAAMeIR2Tiks5r_BY3gaJpZM4Np4vC>
.
--
Derek Riemer: Improving the world one byte at a time!
- University of Colorado Boulder Department of computer science, 4th
year undergraduate student.
- Accessibility enthusiast.
- Proud user of the NVDA screen reader.
- Open source enthusiast.
- Skier.
Personal website <http://derekriemer.com>
|
The browse mode sound is almost entirely left ear. This is a problem because sometimes, I use NVDA with only one ear phone, since I'm in school and want only one headphone on so I can listen with the other ear. |
I’m in agreement with @michaelDCurran<https://github.com/michaeldcurran> regarding NVDA startup and shut down sounds. I don’t’ believe the original sounds are as jarring as people believe. The replacements are too subtle. Reducing the volume of the original sounds by 30 percent or so would accomplish similar goals. I’d vote to keep the original.
|
I suggest that you keep both versions of the sounds. and make it possible to switch between old and new sounds. |
@PratikP1: What comment of mine are you referring to? I am pretty
neutral about the switch.
|
Sorry if I misunderstood the original message in this thread.
|
@PratikP1: No problem. I've now read the actual pr summary where I was
mentioned. I have no major issue with replacing most of the sounds, but
I struggle with the start sound as I'm not quite sure if it denotes an
action or is supposed to be a logo. If the latter than I feel it should
be a little longer and more memorable. But having said this, it does
not change the functionality, nor am I so committed as to suggest
anything better at this stage.
|
@derekriemer commented on May 31, 2017, 7:31 AM GMT+10:
It's actually two different pitches, one in left and one in right, but they're both the same volume to my ear. I tried using NVDA in just my right ear and I could still hear it quite well. Are you saying it seems quieter to you? I guess we could drop it to mono if this is a major issue. @gdata1 commented on May 31, 2017, 7:56 AM GMT+10:
I think this is superfluous. We should either keep the old sounds or switch to new ones. @PratikP1 commented on May 31, 2017, 7:52 AM GMT+10:
One real concern I do have (putting all the others aside) is that the exit sound is long enough that it makes restarts feel slow. Perhaps we should just drop the exit sound. Does it really serve any purpose? On a slow machine, you can argue the startup sound helps you to know sooner that NVDA has started, but exit is user triggered and thus the user should already be consciously aware of this. |
@derekriemer commented on May 31, 2017, 3:51 AM GMT+10:
Um... this PR already does that. |
Oh. I didn't look Lol
…On Tue, May 30, 2017 at 11:33 PM, James Teh ***@***.***> wrote:
***@***.**** <https://github.com/derekriemer> commented on May 31,
2017, 3:51 AM GMT+10
<#7218 (comment)>:
I think you should include all the sound authors in the contributers file
as a thank you.
Um... this PR already does that.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#7218 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AFGivSPAIIfI539UYJ5TGh3wy6OCx0eQks5r_PuigaJpZM4Np4vC>
.
--
Derek Riemer: Improving the world one byte at a time!
- University of Colorado Boulder Department of computer science, 4th
year undergraduate student.
- Accessibility enthusiast.
- Proud user of the NVDA screen reader.
- Open source enthusiast.
- Skier.
Personal website <http://derekriemer.com>
|
Feedback on this PR, #7393, these two nvda-devel threads, social media and elsewhere suggests that while some users are happy with the new sounds, a significant number of users have concerns (e.g. difficulty in discerning the sounds) or are vehemently opposed to them. As a result, we're going to revert this change, and given the amount of difficulty in satisfying various groups, we are not going to consider any alternatives in the near term. Eventually, our aim would be to allow add-ons to more easily provide sound packs. I'm going to lock comments on this PR; further discussion at this point is not useful. Thanks to those who provided feedback. |
…with more modern, subtle sounds.
Link to issue number:
Fixes #5382.
Summary of the issue:
Description of how this pull request fixes the issue:
This PR replaces all of these sounds with subtle, modern, short sounds.
Sounds and images have also been moved from miscDeps into the NVDA repository itself, since they're specific to NVDA (not dependencies) and are quite small. Moving images obviously isn't related to sounds, but I figured it made sense to move these in the process rather than doing more miscDeps churn.
Note that the sounds moved include suggestionsOpened and suggestionsClosed, which are part of #6274 which is not yet in master. However, it will be merged to master soon enough, and again, I wanted to avoid more miscDeps churn.
Testing performed:
These sounds were actually contributed by others. There has been quite a lot of discussion and feedback from these contributors, as well as from @michaelDCurran, @Qchristensen and @derekriemer.
I've been running with these new sounds locally for a couple of weeks.
I've tested that the new sounds apply correctly in a local build.
Known issues with pull request:
Change log entry:
In Changes:
Note that I don't mention the error sound because this won't be noticed by users of stable releases for whom the What's New document is intended.